netdev - Re: [PATCH net-next] ipv6: Move ipv6 stubs to a separate header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57a656dc-5be4-830a-2a54-550d0a62a475@gmail.com>
Date:   Fri, 22 Mar 2019 17:17:52 +0100
From:   David Ahern <dsahern@...il.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>,
        David Ahern <dsahern@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ipv6: Move ipv6 stubs to a separate header file

On 3/22/19 5:14 PM, Alexei Starovoitov wrote:
> On Fri, Mar 22, 2019 at 06:06:09AM -0700, David Ahern wrote:
>> From: David Ahern <dsahern@...il.com>
>>
>> The number of stubs is growing and has nothing to do with addrconf.
>> Move the definition of the stubs to a separate header file and update
>> users. In the move, drop the vxlan specific comment before ipv6_stub.
>>
>> Code move only; no functional change intended.
>>
>> Signed-off-by: David Ahern <dsahern@...il.com>
> 
> nack.
> why this code churn?

This is a prep patch for nexthops as separate objects. I will be adding
4 more functions to the stubs, and I hit a bit of a header nightmare
with it in addrconf.h.

And this has no impact on ipv6 built in or as a module; it has only to
do with a proper header file for a definition.