netdev - Re: [PATCH net v2 1/1] net: sched: fix cleanup NULL pointer exception in act

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpVR2ZtwMfZErrxTPoR4WvZa6s=-U3+3zJMvxLGU5XDiaA@mail.gmail.com>
Date:   Fri, 22 Mar 2019 10:21:09 -0700
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     John Hurley <john.hurley@...ronome.com>
Cc:     Jiri Pirko <jiri@...lanox.com>, David Miller <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        Vlad Buslov <vladbu@...lanox.com>, oss-drivers@...ronome.com
Subject: Re: [PATCH net v2 1/1] net: sched: fix cleanup NULL pointer exception
 in act_mirr

On Fri, Mar 22, 2019 at 5:37 AM John Hurley <john.hurley@...ronome.com> wrote:
>
> A new mirred action is created by the tcf_mirred_init function. This
> contains a list head struct which is inserted into a global list on
> successful creation of a new action. However, after a creation, it is
> still possible to error out and call the tcf_idr_release function. This,
> in turn, calls the act_mirr cleanup function via __tcf_idr_release and
> __tcf_action_put. This cleanup function tries to delete the list entry
> which is as yet uninitialised, leading to a NULL pointer exception.
>
> Fix this by initialising the list entry on creation of a new action.
...
>
> Fixes: 4e232818bd32 ("net: sched: act_mirred: remove dependency on rtnl lock")
> Signed-off-by: John Hurley <john.hurley@...ronome.com>
> Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Acked-by: Cong Wang <xiyou.wangcong@...il.com>

Thanks for the update!