netdev - Re: [PATCH bpf-next v3 00/13] bpf tc tunneling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190322210108.3jftrdhrictbdeu5@ast-mbp.dhcp.thefacebook.com>
Date:   Fri, 22 Mar 2019 14:01:10 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     netdev@...r.kernel.org, ast@...nel.org, daniel@...earbox.net,
        sdf@...gle.com, posk@...gle.com,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH bpf-next v3 00/13] bpf tc tunneling

On Fri, Mar 22, 2019 at 02:32:47PM -0400, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@...gle.com>
> 
> BPF allows for dynamic tunneling, choosing the tunnel destination and
> features on-demand. Extend bpf_skb_adjust_room to allow for efficient
> tunneling at the TC hooks.
> 
> Most features are required for large packets with GSO, as these will
> be modified after this patch.
> 
> Patch 1
>   is a performance optimization, avoiding an unnecessary unclone
>   for the TCP hot path.
> 
> Patches 2..6
>   introduce a regression test. These can be squashed, but the code is
>   arguably more readable when gradually expanding the feature set.
> 
> Patch 7
>   is a performance optimization, avoid copying network headers
>   that are going to be overwritten. This also simplifies the bpf
>   program.
> 
> Patch 8
>   reenables bpf_skb_adjust_room for UDP packets.
> 
> Patch 9
>   configures skb tunneling metadata analogous to tunnel devices.
> 
> Patches 10..13
>   expand the regression test to make use of the new features and
>   enable the GSO testcases.
> 
> Changes
>   v1->v2
>   - move BPF_F_ADJ_ROOM_MASK out of uapi as it can be expanded
>   - document new flags
>   - in tests replace netcat -q flag with coreutils timeout:
>       the -q flag is not supported in all netcat versions
>   v2->v3
>   - move BPF_F_ADJ_ROOM_ENCAP_L3_MASK out of uapi as it has no
>     use in userspace

Applied, Thanks