netdev - Re: [PATCH bpf-next v2] bpf: silence uninitialized var warning in bpf_skb_net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAADnVQ+OL3X0Q48txz0+mfrE347Wwp+AJxxSDGXuVrEyxuc-Ng@mail.gmail.com>
Date:   Sun, 24 Mar 2019 15:33:02 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc:     Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Willem de Bruijn <willemb@...gle.com>,
        kbuild test robot <lkp@...el.com>
Subject: Re: [PATCH bpf-next v2] bpf: silence uninitialized var warning in bpf_skb_net_grow

On Sat, Mar 23, 2019 at 9:23 AM Willem de Bruijn
<willemdebruijn.kernel@...il.com> wrote:
>
> From: Willem de Bruijn <willemb@...gle.com>
>
> These three variables are set in one branch and used in another with
> the same condition. But on some architectures they still generate
> compiler warnings of the kind:
>
>   warning: 'inner_trans' may be used uninitialized in this function [-Wmaybe-uninitialized]
>
> Silence these false positives. Use the straightforward approach to
> always initialize them, if a bit superfluous.
>
> Fixes: 868d523535c2 ("bpf: add bpf_skb_adjust_room encap flags")
> Reported-by: kbuild test robot <lkp@...el.com>
> Signed-off-by: Willem de Bruijn <willemb@...gle.com>

applied. thanks!