netdev - Re: [PATCH] tipc: avoid a clang -Wuninitialized warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190323.214910.174783827736915395.davem@davemloft.net>
Date:   Sat, 23 Mar 2019 21:49:10 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     jon.maloy@...csson.com, ying.xue@...driver.com,
        clang-built-linux@...glegroups.com, ndesaulniers@...gle.com,
        natechancellor@...il.com, tuong.t.lien@...tech.com.au,
        canh.d.luu@...tech.com.au, tung.q.nguyen@...tech.com.au,
        mohan.krishna.ghanta.krishnamurthy@...csson.com,
        netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tipc: avoid a clang -Wuninitialized warning

From: Arnd Bergmann <arnd@...db.de>
Date: Fri, 22 Mar 2019 15:18:13 +0100

> clang notices that we pass 'maddr' into the tipc_bearer_xmit() function
> without having initialized it first:
 ...
> This is harmless because it won't use 'maddr' if the
> queue is empty, but it's better to make that explicit
> and not even call the function in that case.
> 
> As clang is able to inline the check, it then notices that
> the code is safe.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

It looks like Jon's patch took care of this.