netdev - Re: [patch net] net: devlink: skip info_get op call if it is not defined in dumpit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190323200610.1702d8c3@cakuba.netronome.com>
Date:   Sat, 23 Mar 2019 20:06:10 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, mlxsw@...lanox.com,
        idosch@...lanox.com
Subject: Re: [patch net] net: devlink: skip info_get op call if it is not
 defined in dumpit

On Sun, 24 Mar 2019 00:21:03 +0100, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...lanox.com>
> 
> In dumpit, unlike doit, the check for info_get op being defined
> is missing. Add it and avoid null pointer dereference in case driver
> does not define this op.
> 
> Fixes: f9cf22882c60 ("devlink: add device information API")
> Reported-by: Ido Schimmel <idosch@...lanox.com>
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Ugh, looks like the check got lost in v2 somehow.

Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com>

Thanks/sorry!