lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 24 Mar 2019 09:01:54 +0100 From: Jiri Pirko <jiri@...nulli.us> To: Jakub Kicinski <jakub.kicinski@...ronome.com> Cc: netdev@...r.kernel.org, davem@...emloft.net, mlxsw@...lanox.com, idosch@...lanox.com, f.fainelli@...il.com, andrew@...n.ch, vivien.didelot@...il.com Subject: Re: [patch net-next v2 11/15] nfp: move devlink port type set after netdev registration Sun, Mar 24, 2019 at 04:04:05AM CET, jakub.kicinski@...ronome.com wrote: >On Sat, 23 Mar 2019 23:47:50 +0100, Jiri Pirko wrote: >> >type setting. I'd rather those calls happened on fully initialized >> >netdev (and port), could you perhaps just take this patch into the >> >> I don't get it, you are commenting cleanup part. On init, the type set >> happens on fully initialized devlink_port and netdev. > >I'm talking about internal nfp API calls, nfp_app_vnic_init() and >nfp_app_vnic_clean() should be called while vNIC is completely >initialized and registered from stack's PoV. netdev, and devlink >port fully initialized and set up. I don't think it matters much, >just an imperfection. Oh, I get it. Will change the order. Thanks.
Powered by blists - more mailing lists