netdev - Re: [PATCH 7/7] net/utils: Use strlcpy() instead of open-coding it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1553529305.118779.8.camel@acm.org>
Date:   Mon, 25 Mar 2019 08:55:05 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     "Rustad, Mark D" <mark.d.rustad@...el.com>
Cc:     David Miller <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Sagi Grimberg <sagi@...mberg.me>,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 7/7] net/utils: Use strlcpy() instead of open-coding it

On Fri, 2019-03-22 at 18:46 +0000, Rustad, Mark D wrote:
> This doesn't look right to me. The original code seemingly would stop the  
> copy before getting to a possible '%' character. The new code only stops at  
> eol. So this appears to change the functionality and I assume is broken in  
> any case that uses the %. Take another look at what that min_t is really  
> doing.

Hi Mark,

Thanks for the feedback. I will drop this patch.

Bart.