netdev - RE: [PATCH net-next v2] tipc: fix return value check in tipc_mcast_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 25 Mar 2019 16:29:53 +0000
From:   Jon Maloy <jon.maloy@...csson.com>
To:     Wei Yongjun <weiyongjun1@...wei.com>,
        Ying Xue <ying.xue@...driver.com>,
        Hoang Huu Le <hoang.h.le@...tech.com.au>,
        Eric Dumazet <eric.dumazet@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "tipc-discussion@...ts.sourceforge.net" 
        <tipc-discussion@...ts.sourceforge.net>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        Hulk Robot <hulkci@...wei.com>
Subject: RE: [PATCH net-next v2] tipc: fix return value check in
 tipc_mcast_send_sync()

Acked-by: Jon Maloy <jon.maloy@...csson.com>

> -----Original Message-----
> From: netdev-owner@...r.kernel.org <netdev-owner@...r.kernel.org>
> On Behalf Of Wei Yongjun
> Sent: 25-Mar-19 07:31
> To: Jon Maloy <jon.maloy@...csson.com>; Ying Xue
> <ying.xue@...driver.com>; Hoang Huu Le <hoang.h.le@...tech.com.au>;
> Eric Dumazet <eric.dumazet@...il.com>
> Cc: Wei Yongjun <weiyongjun1@...wei.com>; netdev@...r.kernel.org;
> tipc-discussion@...ts.sourceforge.net; kernel-janitors@...r.kernel.org; Hulk
> Robot <hulkci@...wei.com>
> Subject: [PATCH net-next v2] tipc: fix return value check in
> tipc_mcast_send_sync()
> 
> Fix the return value check which testing the wrong variable in
> tipc_mcast_send_sync().
> 
> Fixes: c55c8edafa91 ("tipc: smooth change between replicast and broadcast")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
> v1 -> v2: add reported-by
> ---
>  net/tipc/bcast.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c index
> 88edfb358ae7..76e14dc08bb9 100644
> --- a/net/tipc/bcast.c
> +++ b/net/tipc/bcast.c
> @@ -329,7 +329,7 @@ static int tipc_mcast_send_sync(struct net *net,
> struct sk_buff *skb,
> 
>  	/* Allocate dummy message */
>  	_skb = tipc_buf_acquire(MCAST_H_SIZE, GFP_KERNEL);
> -	if (!skb)
> +	if (!_skb)
>  		return -ENOMEM;
> 
>  	/* Preparing for 'synching' header */
> 
>