netdev - Re: [PATCH net] netlink: fix a memory leak on error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <84e65ccd-d2ee-ed7c-e758-06a8a74312e3@virtuozzo.com>
Date:   Mon, 25 Mar 2019 11:12:45 +0300
From:   Kirill Tkhai <ktkhai@...tuozzo.com>
To:     cgxu519 <cgxu519@....com>, davem@...emloft.net
Cc:     keescook@...omium.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] netlink: fix a memory leak on error path

On 25.03.2019 04:19, cgxu519 wrote:
> On 3/22/19 7:03 PM, Kirill Tkhai wrote:
>> Hi, Chengguang,
>>
>> On 22.03.2019 13:58, Chengguang Xu wrote:
>>> In genl_register_family(), when idr_alloc() fails,
>>> we forget to free family->attrbuf.
>>>
>>> Note, some callers call genl_unregister_family() to clean up
>>> on error path, it doesn't work because the family is inserted
>>> to the global list in the nearly last step.
>>>
>>> Fixes: 2ae0f17df1c ("genetlink: use idr to track families").
>>> Signed-off-by: Chengguang Xu <cgxu519@....com>
>> have you seen https://patchwork.ozlabs.org/patch/1059834/ ?
> 
> Sorry, I didn't notice that because I'm mainly working on linus-tree.
> Please just ignore this patch.

Not a problem.

Some information about network development process you may find in

https://www.kernel.org/doc/Documentation/networking/netdev-FAQ.txt

Kirill