netdev - Re: [PATCH net 1/2] thunderx: enable page recycling for non-XDP case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190326155902.0c0ce9fd@carbon>
Date:   Tue, 26 Mar 2019 15:59:02 +0100
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Dean Nelson <dnelson@...hat.com>
Cc:     Robert Richter <rric@...nel.org>,
        Sunil Goutham <sgoutham@...ium.com>,
        David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Vadim Lomovtsev <vlomovtsev@...vell.com>, brouer@...hat.com
Subject: Re: [PATCH net 1/2] thunderx: enable page recycling for non-XDP
 case

On Tue, 26 Mar 2019 09:44:19 -0500
Dean Nelson <dnelson@...hat.com> wrote:

> On 3/26/19 9:39 AM, Jesper Dangaard Brouer wrote:
> > On Tue, 26 Mar 2019 10:04:47 -0400
> > Dean Nelson <dnelson@...hat.com> wrote:
> >   
> >> Commit 773225388dae15e72790 added code to nicvf_alloc_page() that inadvertently
> >> disables receive buffer page recycling for the non-XDP case by always NULL'ng
> >> the page pointer.
> >>
> >> This patch corrects two if-conditionals to allow for the recycling of non-XDP
> >> mode pages by only setting the page pointer to NULL when the page is not ready
> >> for recycling.
> >>
> >> Signed-off-by: Dean Nelson <dnelson@...hat.com>  
> > 
> > You need to add a "fixes" line like this:
> > 
> > Fixes: 773225388dae ("net: thunderx: Optimize page recycling for XDP")
> > 
> > And in-general reference a commit in the same way in the description.  
> 
> Sorry, for some reason I thought the 'Fixes' line was optional.
> 
> Thank you for setting me straight. Should I repost the patchset?

I would say, yes please. (Given the amount of patches DaveM have to
process, lets make it easy for him).

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer