netdev - Re: [PATCH net-next] ipv6: Move ipv6 stubs to a separate header file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190326151123.uz5g72gfxj2nr7fk@ast-mbp>
Date:   Tue, 26 Mar 2019 08:11:25 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     David Ahern <dsahern@...il.com>
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        edumazet@...gle.com, kafai@...com
Subject: Re: [PATCH net-next] ipv6: Move ipv6 stubs to a separate header file

On Tue, Mar 26, 2019 at 08:19:06AM -0600, David Ahern wrote:
> work needed. To be able to reach certain clear steps and still maintain
> the 20'ish patches in a set requirement, I have sent a few patches which
> are standalone and basically noise - like this one - to avoid
> distractions on the real change.

This patch is far from noise. In the thread you said that you'll be
adding 4 more indirect calls and that rings performance alarms.
retpoline is expensive. If you want to add more indirect calls to fib lookup
it's no go. Benchmarks with retpoline=off won't show the difference.