netdev - Re: [PATCH net] dpaa2-eth: fix race condition with bql frame accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 Mar 2019 11:44:49 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     ioana.ciornei@....com
Cc:     netdev@...r.kernel.org, ruxandra.radulescu@....com
Subject: Re: [PATCH net] dpaa2-eth: fix race condition with bql frame
 accounting

From: Ioana Ciornei <ioana.ciornei@....com>
Date: Mon, 25 Mar 2019 13:06:22 +0000

> It might happen that Tx conf acknowledges a frame before it was
> subscribed in bql, as subscribing was previously done after the enqueue
> operation.
> 
> This patch moves the netdev_tx_sent_queue call before the actual frame
> enqueue, so that this can never happen.
> 
> Fixes: 569dac6 ("dpaa2-eth: bql support")
> Signed-off-by: Ioana Ciornei <ioana.ciornei@....com>

Please always use 12 digits of signifigance for SHA1 values in Fixes: tags
as per the patch submission guidelines.

I fixed it up for you this time.

Applied, thanks.