netdev - Re: [patch net-next v2 12/12] net: devlink: add warning for ndo_get_phys_port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190326133634.484ec760@cakuba.netronome.com>
Date:   Tue, 26 Mar 2019 13:36:34 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, mlxsw@...lanox.com,
        idosch@...lanox.com, f.fainelli@...il.com, andrew@...n.ch,
        vivien.didelot@...il.com, michael.chan@...adcom.com
Subject: Re: [patch net-next v2 12/12] net: devlink: add warning for
 ndo_get_phys_port_name set when not needed

On Tue, 26 Mar 2019 13:03:07 +0100, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...lanox.com>
> 
> Currently if the driver registers devlink port instance, it should set
> the devlink port attributes as well. Then the devlink core is able to
> obtain physical port name itself, no need for driver to implement
> the ndo. Once all drivers will implement devlink port registration,
> this ndo should be removed. This warning guides new
> drivers to do things as they should be done.
> 
> Signed-off-by: Jiri Pirko <jiri@...lanox.com>

Reviewed-by: Jakub Kicinski <jakub.kicinski@...ronome.com>