netdev - Re: [PATCH net-next] tcp: fix zerocopy and notsent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e0dcab2-4e2e-08f8-a131-14fecb900dab@gmail.com>
Date:   Tue, 26 Mar 2019 01:56:05 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>
Cc:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Willem de Bruijn <willemb@...gle.com>
Subject: Re: [PATCH net-next] tcp: fix zerocopy and notsent_lowat issues



On 03/25/2019 01:50 PM, Willem de Bruijn wrote:
> On Mon, Mar 25, 2019 at 4:48 PM Soheil Hassas Yeganeh <soheil@...gle.com> wrote:
>>
>> On Mon, Mar 25, 2019 at 4:44 PM Eric Dumazet <edumazet@...gle.com> wrote:
>>>
>>> My recent patch had at least two problems :
>>>
>>> 1) TX zerocopy wants notification when skb is acknowledged,
>>>    thus we need to call skb_zcopy_clear() if the skb is
>>>    cached into sk->sk_tx_skb_cache
>>>
>>> 2) Some applications might expect precise EPOLLOUT notifications,
>>>    so we need to update sk->sk_wmem_queued and call
>>>    sk_mem_uncharge() from sk_wmem_free_skb() in all cases.
>>>    The SOCK_QUEUE_SHRUNK flag must also be set.
>>>
>>> Fixes: 472c2e07eef0 ("tcp: add one skb cache for tx")
>>> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
>>> Cc: Willem de Bruijn <willemb@...gle.com>
>>> Cc: Soheil Hassas Yeganeh <soheil@...gle.com>
>>
>> Acked-by: Soheil Hassas Yeganeh <soheil@...gle.com>
> 
> Acked-by: Willem de Bruijn <willemb@...gle.com>
> 

Thanks Soheil and Willem

I will send a v2, because I missed the needed changes in tcp_write_queue_purge()