netdev - Re: [PATCH mlx5-next 3/4] net/mlx5: Decrease default mr cache size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ3xEMiMphpkF6B-Ns-+wPcso1Lk=12=jn3ZqLoAB5a-GLfVcw@mail.gmail.com>
Date:   Wed, 27 Mar 2019 12:07:54 +0200
From:   Or Gerlitz <gerlitz.or@...il.com>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...lanox.com>,
        Leon Romanovsky <leonro@...lanox.com>,
        RDMA mailing list <linux-rdma@...r.kernel.org>,
        Artemy Kovalyov <artemyko@...lanox.com>,
        Guy Levi <guyle@...lanox.com>,
        Haggai Eran <haggaie@...lanox.com>,
        Jerome Glisse <jglisse@...hat.com>,
        Moni Shoua <monis@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        linux-netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH mlx5-next 3/4] net/mlx5: Decrease default mr cache size

On Tue, Mar 19, 2019 at 11:25 AM Leon Romanovsky <leon@...nel.org> wrote:
> From: Artemy Kovalyov <artemyko@...lanox.com>
>
> Delete initialization of high order entries in mr cache to decrease initial
> memory footprint. When required, the administrator can populate the
> entries with memory keys via the /sys interface.

Please add here:

This approach is very helpful to reduce the per HW function memory
footprint in environments such as VMs. Before the patch we see
consumption of 0.9GB per function and after the patch about 0.1GB

> Signed-off-by: Artemy Kovalyov <artemyko@...lanox.com>
> Signed-off-by: Moni Shoua <monis@...lanox.com>
> Signed-off-by: Leon Romanovsky <leonro@...lanox.com>

Reported-by:  Shalom Toledo <shalomt@...lanox.com>
Acked-by: Or Gerlitz <ogerlitz@...lanox.com>

Lets push it into stable kernels, a Fixes tag here will cause that
to happen more easily, so please consider that.

> ---
>  .../net/ethernet/mellanox/mlx5/core/main.c    | 20 -------------------
>  1 file changed, 20 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> index 70cc906a102b..76716419370d 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> @@ -164,26 +164,6 @@ static struct mlx5_profile profile[] = {
>                         .size   = 8,
>                         .limit  = 4
>                 },
> -               .mr_cache[16]   = {
> -                       .size   = 8,
> -                       .limit  = 4
> -               },
> -               .mr_cache[17]   = {
> -                       .size   = 8,
> -                       .limit  = 4
> -               },
> -               .mr_cache[18]   = {
> -                       .size   = 8,
> -                       .limit  = 4
> -               },
> -               .mr_cache[19]   = {
> -                       .size   = 4,
> -                       .limit  = 2
> -               },
> -               .mr_cache[20]   = {
> -                       .size   = 4,
> -                       .limit  = 2
> -               },
>         },
>  };
>
> --
> 2.20.1
>