netdev - Re: [PATCH net-next 13/13] net: Use common nexthop init and release helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <58289403-c6a5-1d59-2d90-6bc667b78af5@gmail.com>
Date:   Wed, 27 Mar 2019 08:22:35 -0600
From:   David Ahern <dsahern@...il.com>
To:     Ido Schimmel <idosch@...lanox.com>,
        David Ahern <dsahern@...nel.org>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>
Subject: Re: [PATCH net-next 13/13] net: Use common nexthop init and release
 helpers

On 3/27/19 3:46 AM, Ido Schimmel wrote:
> On Tue, Mar 26, 2019 at 08:29:42PM -0700, David Ahern wrote:
>> From: David Ahern <dsahern@...il.com>
>>
>> With fib_nh_common in place, move common initialization and release
>> code into helpers used by both ipv4 and ipv6. For the moment, the init
>> is just the lwt encap and the release is both the net dev reference and
> 
> s/net dev/netdev/
> 
>> the the lwt state reference. More will be added later.
>>
>> Signed-off-by: David Ahern <dsahern@...il.com>
>> ---
>>  include/net/ip_fib.h     |  4 ++++
>>  net/ipv4/fib_semantics.c | 60 +++++++++++++++++++++++++++++++-----------------
> 
> I don't really mind, but shouldn't the common parts be placed under
> net/core/ ? Like how the FIB rules have a common code in
> net/core/fib_rules.c ?
> 

net/core is for common code across networking protocols.

Code common between just IPv4 and IPv6 is currently in net/ipv4