netdev - "r8169: Reinstate ASPM Support" causes increased packet latency on Asus H87M-E motherboard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190327150546.dgt54rchfumhaap5@mcrowe.com>
Date:   Wed, 27 Mar 2019 15:05:46 +0000
From:   Mike Crowe <mac@...owe.com>
To:     netdev@...r.kernel.org, Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     Chunhao Lin <hau@...ltek.com>
Subject: "r8169: Reinstate ASPM Support" causes increased packet latency on
 Asus H87M-E motherboard

After upgrading the kernel to v4.19 we started seeing increased packet
latency on two machines with ASUS H87M-E motherboards with on-board Realtek
Gigabit Ethernet. This didn't happen with v4.18. (More details, including
kernel log and lspci output at
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=925496 )

Bisecting revealed that commit

 a99790bf5c7f3d68d8b01e015d3212a98ee7bd57  r8169: Reinstate ASPM Support

provoked this change in behaviour.

If I patch v4.9.31's drivers/net/ethernet/realtek/r8169.c
rtl_hw_aspm_clkreq_enable function to never enable the clocks (which,
AFAICT, is equivalent to reverting the aforementioned commit) then packet
latency is normal.

The increased packet latency can also be resolved by:

1. Running 'ethtool -C eth0 rx-usecs 0 rx-frames 1'

2. Disabling "EPU Power Saving Mode" in the BIOS (on the Ai Tweaker page.)
   This option is enabled when the "ASUS Optimal" setting is selected on
   the BIOS front page.

but neither of these solutions are ideal because they require the user to
realise that there's a problem and discover these solutions.

Is there a way to fix the code to work correctly with this motherboard even
with "EPU Power Saving Mode" enabled?

Thanks.

Mike.