netdev - [patch net-next v3 00/12] net: call for phys_port_name into devlink directly if possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Mar 2019 16:19:46 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     netdev@...r.kernel.org
Cc:     davem@...emloft.net, mlxsw@...lanox.com, idosch@...lanox.com,
        jakub.kicinski@...ronome.com, f.fainelli@...il.com, andrew@...n.ch,
        vivien.didelot@...il.com, michael.chan@...adcom.com
Subject: [patch net-next v3 00/12] net: call for phys_port_name into devlink directly if possible

From: Jiri Pirko <jiri@...lanox.com>

phys_port_name may be assembled by a helper in devlink. It is currently
the case only for mlxsw driver. Benefit from the get_devlink_port ndo
and call into devlink directly from dev_get_phys_port_name(). That saves
the trip to the driver, simplifies the code and makes it similar to
recently introduced ethtool-devlink compat helpers.

Move bnxt, dsa and partly nfp to let devlink core generate the name too.

Jiri Pirko (12):
  nfp: register devlink port before netdev
  net: replace ndo_get_devlink with ndo_get_devlink_port
  net: devlink: introduce devlink_compat_phys_port_name_get()
  mlxsw: Implement ndo_get_devlink_port
  mlxsw: Remove ndo_get_phys_port_name implementation
  net: devlink: remove unused devlink_port_get_phys_port_name() function
  bnxt: implement ndo_get_devlink_port
  bnxt: remove ndo_get_phys_port_name implementation
  dsa: implement ndo_get_devlink_port
  dsa: don't fill-up remove ndo_get_phys_port_name for slaves
  nfp: do not handle nn->port defined case in
    nfp_net_get_phys_port_name()
  net: devlink: add warning for ndo_get_phys_port_name set when not
    needed

 drivers/net/ethernet/broadcom/bnxt/bnxt.c     | 26 +++-------
 drivers/net/ethernet/mellanox/mlxsw/core.c    | 10 ++--
 drivers/net/ethernet/mellanox/mlxsw/core.h    |  5 +-
 drivers/net/ethernet/mellanox/mlxsw/minimal.c | 22 ++++-----
 .../net/ethernet/mellanox/mlxsw/spectrum.c    | 22 ++++-----
 .../net/ethernet/mellanox/mlxsw/switchx2.c    | 22 ++++-----
 drivers/net/ethernet/netronome/nfp/nfp_app.h  |  2 +-
 .../net/ethernet/netronome/nfp/nfp_devlink.c  | 10 ++--
 .../ethernet/netronome/nfp/nfp_net_common.c   |  7 ++-
 .../net/ethernet/netronome/nfp/nfp_net_main.c | 32 ++++++------
 .../net/ethernet/netronome/nfp/nfp_net_repr.c |  2 +-
 include/linux/netdevice.h                     |  6 +--
 include/net/devlink.h                         | 25 ++++++++--
 net/core/dev.c                                | 11 +++--
 net/core/devlink.c                            | 41 ++++++++++++++--
 net/dsa/dsa_priv.h                            |  1 +
 net/dsa/legacy.c                              |  2 +-
 net/dsa/slave.c                               | 49 +++++++++++++++++--
 18 files changed, 197 insertions(+), 98 deletions(-)

-- 
2.17.2