netdev - Re: [PATCH v1 1/2] net: phy: mscc: add support for VSC8514 PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190327.112923.2284635623125598604.davem@davemloft.net>
Date:   Wed, 27 Mar 2019 11:29:23 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     Kavyasree.Kotagiri@...rochip.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, hkallweit1@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        quentin.schulz@...tlin.com
Subject: Re: [PATCH v1 1/2] net: phy: mscc: add support for VSC8514 PHY

From: <Kavyasree.Kotagiri@...rochip.com>
Date: Wed, 27 Mar 2019 09:56:13 +0000

> +static u32 vsc85xx_csr_ctrl_phy_read(struct phy_device *phydev,
> +				     u32 target, u32 reg)
> +{
> +	u32 val, val_l, val_h;
> +	unsigned long deadline;

Please order local variable declarations from longest to shortest
line, ie. reverse christmas tree.

> +static int vsc8514_config_init(struct phy_device *phydev)
> +{
> +	int ret, i;
> +	u16 val, addr;
> +	u32 reg;
> +	unsigned long deadline;
> +	struct vsc8531_private *vsc8531 = phydev->priv;

Likewise.