netdev - Re: [patch net-next v2 08/12] dsa: implement ndo_get_devlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190327200122.GF14297@nanopsycho>
Date:   Wed, 27 Mar 2019 21:01:22 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, mlxsw@...lanox.com,
        idosch@...lanox.com, jakub.kicinski@...ronome.com, andrew@...n.ch,
        vivien.didelot@...il.com, michael.chan@...adcom.com
Subject: Re: [patch net-next v2 08/12] dsa: implement ndo_get_devlink_port

Wed, Mar 27, 2019 at 08:54:41PM CET, f.fainelli@...il.com wrote:
>On 3/26/2019 5:03 AM, Jiri Pirko wrote:
>> From: Jiri Pirko <jiri@...lanox.com>
>> 
>> In order for devlink compat functions to work, implement
>> ndo_get_devlink_port. Legacy slaves does not have devlink port instances
>> created for themselves.
>
>Not a big fan of de-duplicating the entire set of netdev_ops for legacy
>vs. non-legacy, can we just check that the devlink instance was r

In nfp, I make legacy and non-legacy ndos to be shared. However there,
they are doing to eventually all use devlink ports. In dsa on the other
hand, I don't think that legacy is going to use devlink port, would it?
I wan't to eventually have WARN_ON in devlink code in case devlink_port
exists and phys_port_name ndo is present at the same time.