netdev - Re: [PATCH net-next] net: dsa: mv88e6xxx: remove unneeded cmode initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190327.134749.421588036813349408.davem@davemloft.net>
Date:   Wed, 27 Mar 2019 13:47:49 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     vivien.didelot@...il.com, andrew@...n.ch, f.fainelli@...il.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: remove unneeded cmode
 initialization

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Sat, 23 Mar 2019 19:45:13 +0100

> This partially reverts ed8fe20205ac ("net: dsa: mv88e6xxx: prevent
> interrupt storm caused by mv88e6390x_port_set_cmode"). I missed
> that chip->ports[].cmode is overwritten anyway by the cmode
> caching in mv88e6xxx_setup().
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
> The old code causes no issues, therefore net-next.

This looks straight forward enough that I'll apply it without others
reviewing it.

Applied, thanks.