netdev - Re: [PATCH net] vrf: check accept_source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHapkUiVWrn_iHcUmt9-HX1tJvYUSS3hA4jMb0mz6gg9+7Ln8A@mail.gmail.com>
Date:   Wed, 27 Mar 2019 17:17:01 -0400
From:   Stephen Suryaputra <ssuryaextr@...il.com>
To:     netdev@...r.kernel.org
Subject: Re: [PATCH net] vrf: check accept_source_route on the original netdevice

Hit send too soon. There is another related problem that I think needs fixing.

On Wed, Mar 27, 2019 at 3:55 PM Stephen Suryaputra <ssuryaextr@...il.com> wrote:
>
> Configuration check to accept source route IP options should be made on the
> incoming netdevice when the skb->dev is an l3mdev master.
>
> Signed-off-by: Stephen Suryaputra <ssuryaextr@...il.com>
> ---
>  net/ipv4/ip_input.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/net/ipv4/ip_input.c b/net/ipv4/ip_input.c
> index ecce2dc78f17..754176222ef6 100644
> --- a/net/ipv4/ip_input.c
> +++ b/net/ipv4/ip_input.c
> @@ -263,6 +263,9 @@ static inline bool ip_rcv_options(struct sk_buff *skb)
>         const struct iphdr *iph;
>         struct net_device *dev = skb->dev;
>
> +       if (netif_is_l3_master(dev))
> +               dev = __dev_get_by_index(dev_net(dev), IPCB(skb)->iif);
> +
>         /* It looks as overkill, because not all
>            IP options require packet mangling.
>            But it is the easiest for now, especially taking
> --
> 2.17.1
>