netdev - Re: [PATCH net-next] inet: switch IP ID generator to siphash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190327.142941.1512477357306126356.davem@davemloft.net>
Date:   Wed, 27 Mar 2019 14:29:41 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        aksecurity@...il.com, benny@...kas.net
Subject: Re: [PATCH net-next] inet: switch IP ID generator to siphash

From: Eric Dumazet <edumazet@...gle.com>
Date: Wed, 27 Mar 2019 12:40:33 -0700

> According to Amit Klein and Benny Pinkas, IP ID generation is too weak
> and might be used by attackers.
> 
> Even with recent net_hash_mix() fix (netns: provide pure entropy for net_hash_mix())
> having 64bit key and Jenkins hash is risky.
> 
> It is time to switch to siphash and its 128bit keys.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Amit Klein <aksecurity@...il.com>
> Reported-by: Benny Pinkas <benny@...kas.net>

Applied to net-next.