netdev - Re: [PATCH net v3] failover: allow name change on IFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 27 Mar 2019 15:31:17 -0700
From:   si-wei liu <si-wei.liu@...cle.com>
To:     "Michael S. Tsirkin" <mst@...hat.com>
Cc:     Stephen Hemminger <stephen@...workplumber.org>,
        sridhar.samudrala@...el.com, davem@...emloft.net, kubakici@...pl,
        alexander.duyck@...il.com, jiri@...nulli.us,
        netdev@...r.kernel.org, virtualization@...ts.linux-foundation.org,
        liran.alon@...cle.com, boris.ostrovsky@...cle.com,
        vijay.balakrishna@...cle.com
Subject: Re: [PATCH net v3] failover: allow name change on IFF_UP slave
 interfaces



On 3/27/2019 3:16 PM, Michael S. Tsirkin wrote:
> On Wed, Mar 27, 2019 at 01:10:10PM -0700, si-wei liu wrote:
>> Another less safer option is that we just notify userspace anyway without
>> sending down/up event around, as I don't see *any real application* cares
>> about the link state or whatsoever when it attempts to detect rename.
> How do you write a race ree handler then? ATM just detecting link up is
> sufficient and covers 100% of cases. Seems like a good idea to keep it
> that way.
>
What do you mean? Which flag or attribute do you think 100% of the 
userspace regard it as link up? And why userspace that cares about name 
change needs to double check whether link is up or not? I'm sorry, but 
are you sure this is the 100% case that every userspace app does it like 
what you're claiming?

-Siwei