netdev - Re: [PATCH ipsec] esp4: add length check for UDP encapsulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190327082454.GO25855@gauss3.secunet.de>
Date:   Wed, 27 Mar 2019 09:24:54 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Sabrina Dubroca <sd@...asysnail.net>
CC:     <netdev@...r.kernel.org>
Subject: Re: [PATCH ipsec] esp4: add length check for UDP encapsulation

On Mon, Mar 25, 2019 at 02:30:00PM +0100, Sabrina Dubroca wrote:
> esp_output_udp_encap can produce a length that doesn't fit in the 16
> bits of a UDP header's length field. In that case, we'll send a
> fragmented packet whose length is larger than IP_MAX_MTU (resulting in
> "Oversized IP packet" warnings on receive) and with a bogus UDP
> length.
> 
> To prevent this, add a length check to esp_output_udp_encap and return
>  -EMSGSIZE on failure.
> 
> This seems to be older than git history.
> 
> Signed-off-by: Sabrina Dubroca <sd@...asysnail.net>

Applied, thanks a lot Sabrina!