netdev - Re: [PATCH net-next 08/13] ipv6: Refactor fib6_ignore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190327091914.GA16487@splinter>
Date:   Wed, 27 Mar 2019 09:19:17 +0000
From:   Ido Schimmel <idosch@...lanox.com>
To:     David Ahern <dsahern@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH net-next 08/13] ipv6: Refactor fib6_ignore_linkdown

On Tue, Mar 26, 2019 at 08:29:37PM -0700, David Ahern wrote:
> From: David Ahern <dsahern@...il.com>
> 
> fib6_ignore_linkdown takes a fib6_info but only looks at the net_device
> and its IPv6 config. Change it to take a net_device over a fib6_info as
> its input argument.
> 
> In addition, move it to a header file to make the check inline and usable
> later with IPv4 code without going through the ipv6 stub, and rename to
> ip6_ignore_linkdown since it is only checking the setting based on the
> ipv6 struct on a device.
> 
> Signed-off-by: David Ahern <dsahern@...il.com>

Reviewed-by: Ido Schimmel <idosch@...lanox.com>