netdev - Re: [PATCH v3 net-next 07/13] ipv6: Move gateway checks to a fib6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190328112032.GC19672@splinter>
Date:   Thu, 28 Mar 2019 11:20:35 +0000
From:   Ido Schimmel <idosch@...lanox.com>
To:     David Ahern <dsahern@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH v3 net-next 07/13] ipv6: Move gateway checks to a fib6_nh
 setting

On Wed, Mar 27, 2019 at 08:53:52PM -0700, David Ahern wrote:
> From: David Ahern <dsahern@...il.com>
> 
> The gateway setting is not per fib6_info entry but per-fib6_nh. Add a new
> fib_nh_has_gw flag to fib6_nh and convert references to RTF_GATEWAY to
> the new flag. For IPv6 address the flag is cheaper than checking that
> nh_gw is non-0 like IPv4 does.
> 
> While this increases fib6_nh by 8-bytes, the effective allocation size of
> a fib6_info is unchanged. The 8 bytes is recovered later with a
> fib_nh_common change.
> 
> Signed-off-by: David Ahern <dsahern@...il.com>

Reviewed-by: Ido Schimmel <idosch@...lanox.com>