netdev - Re: [PATCH v2 net-next 05/13] ipv6: Create init helper for fib6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fec9230e-5796-f283-98ff-d07311aa3c2d@gmail.com>
Date:   Wed, 27 Mar 2019 20:50:19 -0600
From:   David Ahern <dsahern@...il.com>
To:     Alexei Starovoitov <alexei.starovoitov@...il.com>
Cc:     David Ahern <dsahern@...nel.org>, davem@...emloft.net,
        netdev@...r.kernel.org, idosch@...lanox.com, jiri@...lanox.com,
        saeedm@...lanox.com
Subject: Re: [PATCH v2 net-next 05/13] ipv6: Create init helper for fib6_nh

On 3/27/19 8:29 PM, Alexei Starovoitov wrote:]\
> that was a typo. I meant fib6_flags.
> why mess with cfg and use it as weird side effect only to
> get rt->fib6_flags = cfg->fc_flags; working after fib6_nh_init() returns?
> Why not to move that fib6_flags = fc_flags assignment into fib6_nh_init ?
> Then cfg can stay constant and no weird side effects from init function.
> 

Because fib6_flags is not a nh_init argument and it should not be.

I will duplicate that check to appease your request of not touching
cfg->flags.