netdev - Re: [PATCH bpf] bpf, libbpf: fix quiet install

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEf4BzZ+iQhqdpz33HF3mA95x8+cokmqfL6peGZeicb=HtaWyQ@mail.gmail.com>
Date:   Thu, 28 Mar 2019 09:00:29 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     Alexei Starovoitov <ast@...nel.org>, bpf@...r.kernel.org,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH bpf] bpf, libbpf: fix quiet install_headers

On Thu, Mar 28, 2019 at 8:54 AM Daniel Borkmann <daniel@...earbox.net> wrote:
>
> Both btf.h and xsk.h headers are not installed quietly due to
> missing '\' for the call to QUIET_INSTALL. Lets fix it.
>
> Before:
>
>   # make install_headers
>     INSTALL  headers
>   if [ ! -d '''/usr/local/include/bpf' ]; then install -d -m 755 '''/usr/local/include/bpf'; fi; install btf.h -m 644 '''/usr/local/include/bpf';
>   if [ ! -d '''/usr/local/include/bpf' ]; then install -d -m 755 '''/usr/local/include/bpf'; fi; install xsk.h -m 644 '''/usr/local/include/bpf';
>   # ls /usr/local/include/bpf/
>   bpf.h  btf.h  libbpf.h  xsk.h
>
> After:
>
>   # make install_headers
>     INSTALL  headers
>   # ls /usr/local/include/bpf/
>   bpf.h  btf.h  libbpf.h  xsk.h
>
> Fixes: a493f5f9d8c2 ("libbpf: Install btf.h with libbpf")
> Fixes: 379e2014c95b ("libbpf: add xsk.h to install_headers target")
> Signed-off-by: Daniel Borkmann <daniel@...earbox.net>
> ---

Acked-by: Andrii Nakryiko <andriin@...com>

>  tools/lib/bpf/Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/lib/bpf/Makefile b/tools/lib/bpf/Makefile
> index 7beec4d..8e7c56e 100644
> --- a/tools/lib/bpf/Makefile
> +++ b/tools/lib/bpf/Makefile
> @@ -220,8 +220,8 @@ install_lib: all_cmd
>  install_headers:
>         $(call QUIET_INSTALL, headers) \
>                 $(call do_install,bpf.h,$(prefix)/include/bpf,644); \
> -               $(call do_install,libbpf.h,$(prefix)/include/bpf,644);
> -               $(call do_install,btf.h,$(prefix)/include/bpf,644);
> +               $(call do_install,libbpf.h,$(prefix)/include/bpf,644); \
> +               $(call do_install,btf.h,$(prefix)/include/bpf,644); \
>                 $(call do_install,xsk.h,$(prefix)/include/bpf,644);
>
>  install: install_lib
> --
> 2.9.5
>