netdev - Re: [patch net-next 00/12] net: expose switch ID via devlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190328144002.245c9eef@cakuba.netronome.com>
Date:   Thu, 28 Mar 2019 14:40:02 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, mlxsw@...lanox.com,
        idosch@...lanox.com, f.fainelli@...il.com, andrew@...n.ch,
        vivien.didelot@...il.com, michael.chan@...adcom.com
Subject: Re: [patch net-next 00/12] net: expose switch ID via devlink

On Thu, 28 Mar 2019 22:12:42 +0100, Jiri Pirko wrote:
> From: Jiri Pirko <jiri@...lanox.com>
> 
> To provide visibility of the ports, this patchset exposes switch ID
> for devlink ports, which are part of a switch. The rest of the ports
> if any (in case of sr-iov for example) do not set switch ID.

I don't feel good about this patch set.  There is no visibility
provided here.  Should the port flavour should be a sufficient
indication of whether netdev associated with that port can be 
switched to or not?  CPU, DSA, and Host flavours can't be switched 
to.  And the switchid can be an attribute of the devlink instance,
if we want to expose it via devlink.