netdev - Re: [PATCH] net: dsa: Implement flow_dissect callback for tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Mar 2019 12:37:43 +0800
From:   xiaofeis@...eaurora.org
To:     Vinod Koul <vkoul@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, andrew@...n.ch,
        linux-arm-msm@...r.kernel.org, bjorn.andersson@...aro.org,
        vivien.didelot@...il.com, f.fainelli@...il.com,
        niklas.cassel@...aro.org, xiazha@...eaurora.org
Subject: Re: [PATCH] net: dsa: Implement flow_dissect callback for tag_qca

On 2019-03-27 18:15, Vinod Koul wrote:
> On 27-03-19, 11:59, xiaofeis wrote:
>> Add flow_dissect for qca tagged packet to get the right hash.
> 
> Ideally this patch should have been tagged as V2. Anyhow the change
> looks fine so:
> 
> Reviewed-by: Vinod Koul <vkoul@...nel.org>
> 
>> Signed-off-by: Xiaofei Shen <xiaofeis@...eaurora.org>
>> ---
>>  net/dsa/tag_qca.c | 10 ++++++++++
>>  1 file changed, 10 insertions(+)
>> 
>> diff --git a/net/dsa/tag_qca.c b/net/dsa/tag_qca.c
>> index e886a3c..f4b4de3 100644
>> --- a/net/dsa/tag_qca.c
>> +++ b/net/dsa/tag_qca.c
>> @@ -113,8 +113,18 @@ static struct sk_buff *qca_tag_rcv(struct sk_buff 
>> *skb, struct net_device *dev,
>>  	return skb;
>>  }
>> 
>> +static int qca_tag_flow_dissect(const struct sk_buff *skb, __be16 
>> *proto,
>> +                                int *offset)
>> +{
>> +	*offset = QCA_HDR_LEN;
>> +	*proto = ((__be16 *)skb->data)[0];
>> +
>> +	return 0;
>> +}
>> +
>>  const struct dsa_device_ops qca_netdev_ops = {
>>  	.xmit	= qca_tag_xmit,
>>  	.rcv	= qca_tag_rcv,
>> +	.flow_dissect = qca_tag_flow_dissect,
>>  	.overhead = QCA_HDR_LEN,
>>  };
>> --
>> 1.9.1
Thanks Vinod, will take care next time.