netdev - Re: [PATCH] tools/perf/util: Remove duplicate headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <599c35c3-88b8-f007-9eee-d7fddb1cb31b@codeaurora.org>
Date:   Thu, 28 Mar 2019 11:57:13 +0530
From:   Mukesh Ojha <mojha@...eaurora.org>
To:     jagdsh.linux@...il.com, peterz@...radead.org, mingo@...hat.com,
        acme@...nel.org, alexander.shishkin@...ux.intel.com,
        jolsa@...hat.com, namhyung@...nel.org, ast@...nel.org,
        kafai@...com, songliubraving@...com, yhs@...com,
        yao.jin@...ux.intel.com, eranian@...gle.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        bpf@...r.kernel.org
Subject: Re: [PATCH] tools/perf/util: Remove duplicate headers


On 3/28/2019 3:37 AM, jagdsh.linux@...il.com wrote:
> From: Jagadeesh Pagadala <jagdsh.linux@...il.com>
>
> Remove duplicate headers which are included twice.
> Signed-off-by: Jagadeesh Pagadala <jagdsh.linux@...il.com>

Reviewed-by: Mukesh Ojha <mojha@...eaurora.org>

-Mukesh

> ---
>   tools/perf/util/annotate.c             | 1 -
>   tools/perf/util/data.c                 | 1 -
>   tools/perf/util/get_current_dir_name.c | 1 -
>   tools/perf/util/stat-display.c         | 1 -
>   4 files changed, 4 deletions(-)
>
> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
> index c8b0117..b1dd021 100644
> --- a/tools/perf/util/annotate.c
> +++ b/tools/perf/util/annotate.c
> @@ -36,7 +36,6 @@
>   #include <pthread.h>
>   #include <linux/bitops.h>
>   #include <linux/kernel.h>
> -#include <bpf/libbpf.h>
>   
>   /* FIXME: For the HE_COLORSET */
>   #include "ui/browser.h"
> diff --git a/tools/perf/util/data.c b/tools/perf/util/data.c
> index 6a64f71..509a41e 100644
> --- a/tools/perf/util/data.c
> +++ b/tools/perf/util/data.c
> @@ -8,7 +8,6 @@
>   #include <unistd.h>
>   #include <string.h>
>   #include <asm/bug.h>
> -#include <sys/types.h>
>   #include <dirent.h>
>   
>   #include "data.h"
> diff --git a/tools/perf/util/get_current_dir_name.c b/tools/perf/util/get_current_dir_name.c
> index 267aa60..ebb80cd 100644
> --- a/tools/perf/util/get_current_dir_name.c
> +++ b/tools/perf/util/get_current_dir_name.c
> @@ -5,7 +5,6 @@
>   #include "util.h"
>   #include <unistd.h>
>   #include <stdlib.h>
> -#include <stdlib.h>
>   
>   /* Android's 'bionic' library, for one, doesn't have this */
>   
> diff --git a/tools/perf/util/stat-display.c b/tools/perf/util/stat-display.c
> index 6d043c7..7b3a16c 100644
> --- a/tools/perf/util/stat-display.c
> +++ b/tools/perf/util/stat-display.c
> @@ -12,7 +12,6 @@
>   #include "string2.h"
>   #include "sane_ctype.h"
>   #include "cgroup.h"
> -#include <math.h>
>   #include <api/fs/fs.h>
>   
>   #define CNTR_NOT_SUPPORTED	"<not supported>"