netdev - Re: [PATCH v3 net-next 05/13] ipv6: Create init helper for fib6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190328111732.GA19672@splinter>
Date:   Thu, 28 Mar 2019 11:17:35 +0000
From:   Ido Schimmel <idosch@...lanox.com>
To:     David Ahern <dsahern@...nel.org>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Jiri Pirko <jiri@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        David Ahern <dsahern@...il.com>
Subject: Re: [PATCH v3 net-next 05/13] ipv6: Create init helper for fib6_nh

On Wed, Mar 27, 2019 at 08:53:50PM -0700, David Ahern wrote:
> From: David Ahern <dsahern@...il.com>
> 
> Similar to IPv4, consolidate the fib6_nh initialization into a helper.
> As a new standalone function, add a cleanup path to put lwtstate on
> error.
> 
> To avoid modifying fib6_config flags, move the reject check to a helper
> that is invoked once by fib6_nh_init to reset the device and then
> again in ip6_route_info_create to set the fib6_flags.
> 
> Signed-off-by: David Ahern <dsahern@...il.com>

Reviewed-by: Ido Schimmel <idosch@...lanox.com>