lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Thu, 28 Mar 2019 17:01:56 -0700 (PDT)
From:   David Miller <>
Subject: Re: [PATCH net] netns: provide pure entropy for net_hash_mix()

From: Eric Dumazet <>
Date: Wed, 27 Mar 2019 08:21:30 -0700

> net_hash_mix() currently uses kernel address of a struct net,
> and is used in many places that could be used to reveal this
> address to a patient attacker, thus defeating KASLR, for
> the typical case (initial net namespace, &init_net is
> not dynamically allocated)
> I believe the original implementation tried to avoid spending
> too many cycles in this function, but security comes first.
> Also provide entropy regardless of CONFIG_NET_NS.
> Fixes: 0b4419162aa6 ("netns: introduce the net_hash_mix "salt" for hashes")
> Signed-off-by: Eric Dumazet <>
> Reported-by: Amit Klein <>
> Reported-by: Benny Pinkas <>

Applied and queued up for -stable, thanks.

Powered by blists - more mailing lists