netdev - Re: [PATCH net 0/2] nfp: fix retcode and disable netpoll on representors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190328172750.05e30c6c@cakuba.netronome.com>
Date:   Thu, 28 Mar 2019 17:27:50 -0700
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     David Miller <davem@...emloft.net>
Cc:     oss-drivers@...ronome.com, netdev@...r.kernel.org
Subject: Re: [PATCH net 0/2] nfp: fix retcode and disable netpoll on
 representors

On Thu, 28 Mar 2019 17:04:53 -0700 (PDT), David Miller wrote:
> From: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Date: Wed, 27 Mar 2019 11:38:37 -0700
> 
> > This series avoids a potential crash on nfp representor devices
> > when netpoll is in use.  If transmitting the frame through underlying
> > vNIC fails we'd return an error code (by passing on error code from
> > __dev_queue_xmit()) and cause double free in netpoll code.
> > 
> > Fix the error code and disable netpoll on reprs altogether.
> > IRQ-safety of locking the queues and calling __dev_queue_xmit()
> > is questionable.
> > 
> > Big thanks to John Hurley for debugging and narrowing down
> > the trace log after I gave up! :)  
> 
> Series applied, thanks Jakub.
> 
> Want me to queue these up for -stable?

Mm.. yes, I think so, patch 1 can lead to a hard to catch double free.

Thanks!