netdev - Re: [PATCH net V5 1/2] net/sched: taprio: fix picos_per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 30 Mar 2019 04:46:48 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Leandro Dorileo <leandro.maciel.dorileo@...el.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        "David S . Miller" <davem@...emloft.net>,
        Vinicius Costa Gomes <vinicius.gomes@...el.com>,
        f.fainelli@...il.com, vedang.patel@...el.com,
        andre.guedes@...el.com
Subject: Re: [PATCH net V5 1/2] net/sched: taprio: fix picos_per_byte
 miscalculation

Hi Leandro,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on net/master]

url:    https://github.com/0day-ci/linux/commits/Leandro-Dorileo/net-sched-taprio-fix-picos_per_byte-miscalculation/20190329-185809
config: i386-randconfig-l0-03292131 (attached as .config)
compiler: gcc-5 (Debian 5.5.0-3) 5.4.1 20171010
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   net/sched/sch_taprio.o: In function `ktime_compare':
>> include/linux/ktime.h:116: undefined reference to `__divdi3'
   net/sched/sch_taprio.o: In function `__write_once_size':
>> include/linux/compiler.h:219: undefined reference to `__divdi3'
>> include/linux/compiler.h:219: undefined reference to `__divdi3'

vim +116 include/linux/ktime.h

97fc79f9 Thomas Gleixner 2006-01-09  101  
398f382c Daniel Borkmann 2012-10-28  102  /**
398f382c Daniel Borkmann 2012-10-28  103   * ktime_compare - Compares two ktime_t variables for less, greater or equal
398f382c Daniel Borkmann 2012-10-28  104   * @cmp1:	comparable1
398f382c Daniel Borkmann 2012-10-28  105   * @cmp2:	comparable2
398f382c Daniel Borkmann 2012-10-28  106   *
36019265 Yacine Belkadi  2013-07-24  107   * Return: ...
398f382c Daniel Borkmann 2012-10-28  108   *   cmp1  < cmp2: return <0
398f382c Daniel Borkmann 2012-10-28  109   *   cmp1 == cmp2: return 0
398f382c Daniel Borkmann 2012-10-28  110   *   cmp1  > cmp2: return >0
398f382c Daniel Borkmann 2012-10-28  111   */
398f382c Daniel Borkmann 2012-10-28  112  static inline int ktime_compare(const ktime_t cmp1, const ktime_t cmp2)
398f382c Daniel Borkmann 2012-10-28  113  {
2456e855 Thomas Gleixner 2016-12-25  114  	if (cmp1 < cmp2)
398f382c Daniel Borkmann 2012-10-28  115  		return -1;
2456e855 Thomas Gleixner 2016-12-25 @116  	if (cmp1 > cmp2)
398f382c Daniel Borkmann 2012-10-28  117  		return 1;
398f382c Daniel Borkmann 2012-10-28  118  	return 0;
398f382c Daniel Borkmann 2012-10-28  119  }
398f382c Daniel Borkmann 2012-10-28  120  

:::::: The code at line 116 was first introduced by commit
:::::: 2456e855354415bfaeb7badaa14e11b3e02c8466 ktime: Get rid of the union

:::::: TO: Thomas Gleixner <tglx@...utronix.de>
:::::: CC: Thomas Gleixner <tglx@...utronix.de>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (28806 bytes)