netdev - Re: [patch net-next 00/12] net: expose switch ID via devlink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34644847-01d5-5bba-85b9-6c3af41a9b07@gmail.com>
Date:   Fri, 29 Mar 2019 15:04:05 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org,
        davem@...emloft.net, mlxsw@...lanox.com, idosch@...lanox.com,
        andrew@...n.ch, vivien.didelot@...il.com, michael.chan@...adcom.com
Subject: Re: [patch net-next 00/12] net: expose switch ID via devlink

On 3/29/19 2:57 PM, Jakub Kicinski wrote:
> On Fri, 29 Mar 2019 14:29:11 -0700, Florian Fainelli wrote:
>>> Out of curiosity, what are the shared features?  It seems mlx5 drives 
>>> a lot of our API design, it'd be good if the community had a better
>>> understanding of it.
>>>
>>> The situation with pipelined devices is somewhat murky.  Didn't Or add
>>> some from of PCIe-side looped queue to forward between PFs?
>>>
>>> Presumably DSA would lean the opposite way with multiple ASICs
>>> reporting the same ID?  
>>
>> If you have multiple switches inter connected between each other to use
>> the "D" in DSA and form a fabric of switches, then you would expect each
>> port to be physically tied to a particular switch device/instance,
>> because, but how they will report the switch physical ID can be of the form:
>>
>> <fabric>.<switch>
>>
>> where fabric is dst->index and switch is ds->index (the switch within
>> the fabric).
> 
> Oh, I assumed you'd want the to all have the same switchid, and then
> the "D" in DSA logic makes sure the flooding etc. works across the
> ASICs..

That's a good point, they need to have the switch skb->fwd_offload_mark
to work, so yes, that should be the fabric's index then.
-- 
Florian