netdev - RE: [PATCH mlx5-next 08/14] net/mlx5: Make mlx5_core messages independent from mdev->pdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0501MB227107067F2AFD526AB30A39D15A0@VI1PR0501MB2271.eurprd05.prod.outlook.com>
Date:   Fri, 29 Mar 2019 22:44:16 +0000
From:   Parav Pandit <parav@...lanox.com>
To:     Saeed Mahameed <saeedm@...lanox.com>,
        "saeed@...lanox.com" <saeed@...lanox.com>,
        Leon Romanovsky <leonro@...lanox.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        Huy Nguyen <huyn@...lanox.com>, Vu Pham <vuhuong@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>
Subject: RE: [PATCH mlx5-next 08/14] net/mlx5: Make mlx5_core messages
 independent from mdev->pdev



> -----Original Message-----
> From: netdev-owner@...r.kernel.org <netdev-owner@...r.kernel.org> On
> Behalf Of Saeed Mahameed
> Sent: Friday, March 29, 2019 5:38 PM
> To: saeed@...lanox.com; Leon Romanovsky <leonro@...lanox.com>
> Cc: netdev@...r.kernel.org; linux-rdma@...r.kernel.org; Huy Nguyen
> <huyn@...lanox.com>; Vu Pham <vuhuong@...lanox.com>; Saeed
> Mahameed <saeedm@...lanox.com>
> Subject: [PATCH mlx5-next 08/14] net/mlx5: Make mlx5_core messages
> independent from mdev->pdev
> 
> From: Huy Nguyen <huyn@...lanox.com>
> 
> Detach mlx5_core mdev messages from pci device mdev->pdev messages and
> provide a better report/debug of different mlx5 device types.
> 
> This patch does not change any functionality.
> 
> Signed-off-by: Huy Nguyen <huyn@...lanox.com>
> Signed-off-by: Vu Pham <vuhuong@...lanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>
> ---
>  .../ethernet/mellanox/mlx5/core/mlx5_core.h   | 19 +++++++++----------
>  1 file changed, 9 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h
> b/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h
> index 7b331674622c..052e81974c3b 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h
> @@ -48,12 +48,12 @@
>  extern uint mlx5_core_debug_mask;
> 
>  #define mlx5_core_dbg(__dev, format, ...)				\
> -	dev_dbg(&(__dev)->pdev->dev, "%s:%d:(pid %d): " format,
> 	\
> +	pr_debug("%s:%s:%d:(pid %d): " format, (__dev)->priv.name,      \
>  		 __func__, __LINE__, current->pid,			\
>  		 ##__VA_ARGS__)
> 
>  #define mlx5_core_dbg_once(__dev, format, ...)
> 	\
> -	dev_dbg_once(&(__dev)->pdev->dev, "%s:%d:(pid %d): " format,
> 	\
> +	pr_debug_once("%s:%s:%d:(pid %d): " format, (__dev)->priv.name, \
>  		     __func__, __LINE__, current->pid,			\
>  		     ##__VA_ARGS__)
> 
> @@ -64,28 +64,27 @@ do {
> 			\
>  } while (0)
> 
>  #define mlx5_core_err(__dev, format, ...)				\
> -	dev_err(&(__dev)->pdev->dev, "%s:%d:(pid %d): " format,	\
> +	pr_err("%s:%s:%d:(pid %d): " format, (__dev)->priv.name,        \
>  		__func__, __LINE__, current->pid,	\
>  	       ##__VA_ARGS__)
> 
> -#define mlx5_core_err_rl(__dev, format, ...)				\
> -	dev_err_ratelimited(&(__dev)->pdev->dev,			\
> -			   "%s:%d:(pid %d): " format,			\
> -			   __func__, __LINE__, current->pid,		\
> +#define mlx5_core_err_rl(__dev, format, ...)				     \
> +	pr_err_ratelimited("%s:%s:%d:(pid %d): " format, (__dev)->priv.name,
> \
> +			   __func__, __LINE__, current->pid,		     \
>  			   ##__VA_ARGS__)
> 
>  #define mlx5_core_warn(__dev, format, ...)				\
> -	dev_warn(&(__dev)->pdev->dev, "%s:%d:(pid %d): " format,	\
> +	pr_warn("%s:%s:%d:(pid %d): " format, (__dev)->priv.name,       \
>  		 __func__, __LINE__, current->pid,			\
>  		##__VA_ARGS__)
> 
>  #define mlx5_core_warn_once(__dev, format, ...)
> 	\
> -	dev_warn_once(&(__dev)->pdev->dev, "%s:%d:(pid %d): " format,
> 	\
> +	pr_warn_once("%s:%s:%d:(pid %d): " format, (__dev)->priv.name,  \
>  		      __func__, __LINE__, current->pid,			\
>  		      ##__VA_ARGS__)
> 
>  #define mlx5_core_info(__dev, format, ...)				\
> -	dev_info(&(__dev)->pdev->dev, format, ##__VA_ARGS__)
> +	pr_info("%s " format, (__dev)->priv.name, ##__VA_ARGS__)
> 
>  enum {
>  	MLX5_CMD_DATA, /* print command payload only */
> --
> 2.20.1

Since internal script missed to add the RB tag,

Reviewed-by: Parav Pandit <parav@...lanox.com>