lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20190329.105652.1950793642095951687.davem@davemloft.net> Date: Fri, 29 Mar 2019 10:56:52 -0700 (PDT) From: David Miller <davem@...emloft.net> To: Markus.Amend@...ekom.de Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org, dccp@...r.kernel.org Subject: Re: [PATCH v2] net: dccp: Checksum verification enhancement From: <Markus.Amend@...ekom.de> Date: Tue, 26 Mar 2019 08:54:41 +0000 > Modify checksum verification to allow the validation of skb->ip_summed, in case the checksum has already been verified in lower layers. Please format your commit message to ~80 column lines. > @@ -763,8 +763,9 @@ int dccp_invalid_packet(struct sk_buff *skb) > } > > /* If header checksum is incorrect, drop packet and return. > - * (This step is completed in the AF-dependent functions.) */ > - skb->csum = skb_checksum(skb, 0, cscov, 0); > + * (This step is completed in the AF-dependent functions.) > + * skb->csum = skb_checksum(skb, 0, cscov, 0); > + */ Please do not just comment out code, explain what is operation can be expected to be done already here and why.
Powered by blists - more mailing lists