netdev - Re: [PATCH net] r8169: disable default rx interrupt coalescing on RTL8168

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190330.110617.1344047860723685932.davem@davemloft.net>
Date:   Sat, 30 Mar 2019 11:06:17 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     nic_swsd@...ltek.com, netdev@...r.kernel.org, mac@...owe.com
Subject: Re: [PATCH net] r8169: disable default rx interrupt coalescing on
 RTL8168

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Sat, 30 Mar 2019 17:13:24 +0100

> It was reported that re-introducing ASPM, in combination with RX
> interrupt coalescing, results in significantly increased packet
> latency, see [0]. Disabling ASPM or RX interrupt coalescing fixes
> the issue. Therefore change the driver's default to disable RX
> interrupt coalescing. Users still have the option to enable RX
> coalescing via ethtool.
> 
> [0] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=925496
> 
> Fixes: a99790bf5c7f ("r8169: Reinstate ASPM Support")
> Reported-by: Mike Crowe <mac@...owe.com>
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied and queued up for -stable.

Frankly, I think we were better off with ASPM disabled.  But I know
a lot of people find that unacceptable.

This chip has some many quirks/warts when ASPM is enabled, look how
long it took us to A) get ASPM enabled reasonably and B) discover
this bug.