netdev - Re: [PATCH net-next 3/8] ipv4: Move cached routes to fib_nh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fed100b4-9f7d-8612-ae44-0edc59543880@gmail.com>
Date:   Sat, 30 Mar 2019 18:11:56 -0600
From:   David Ahern <dsahern@...il.com>
To:     David Ahern <dsahern@...nel.org>, davem@...emloft.net,
        netdev@...r.kernel.org
Cc:     idosch@...lanox.com
Subject: Re: [PATCH net-next 3/8] ipv4: Move cached routes to fib_nh_common

On 3/29/19 6:47 PM, David Ahern wrote:
> From: David Ahern <dsahern@...il.com>
> 
> While the cached routes, nh_pcpu_rth_output and nh_rth_input, are IPv4
> specific, a later patch wants to make them accessible for IPv6
> gateways with IPv4 routes but also allow IPv6 routes to have their own
> cached entries. Move the IPv4 cached routes from fib_nh to fib_nh_common
> and update references.
> 
> Signed-off-by: David Ahern <dsahern@...il.com>
> ---
>  include/net/ip_fib.h     |  6 ++++--
>  net/ipv4/fib_semantics.c | 33 +++++++++++++++++----------------
>  net/ipv4/route.c         | 18 +++++++++---------
>  3 files changed, 30 insertions(+), 27 deletions(-)
> 
> diff --git a/include/net/ip_fib.h b/include/net/ip_fib.h
> index 5070bc531ca4..cce437a1b2ff 100644
> --- a/include/net/ip_fib.h
> +++ b/include/net/ip_fib.h
> @@ -92,6 +92,10 @@ struct fib_nh_common {
>  
>  	int			nhc_weight;
>  	atomic_t		nhc_upper_bound;
> +
> +	/* v4 specific, but allows v6 gw with v4 routes */
> +	struct rtable __rcu * __percpu *nhc_pcpu_rth_output;
> +	struct rtable __rcu     *nhc_rth_input;
>  };
>  

Dave: please drop this set. I need to take another look at the
combinations and make sure I did not miss something.