lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 31 Mar 2019 12:45:49 +0530 From: Mukesh Ojha <mojha@...eaurora.org> To: Colin King <colin.king@...onical.com>, Stanislaw Gruszka <sgruszka@...hat.com>, Kalle Valo <kvalo@...eaurora.org>, "David S . Miller" <davem@...emloft.net>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] iwlegacy: remove redundant assignment to *res On 3/31/2019 1:44 AM, Colin King wrote: > From: Colin Ian King <colin.king@...onical.com> > > Currently 1 is being assigned to *res and then it is immediately > updated with the computed result. The first assignment is > redundant and can be removed. > > Signed-off-by: Colin Ian King <colin.king@...onical.com> Reviewed-by: Mukesh Ojha <mojha@...eaurora.org> Cheers, -Mukesh > --- > drivers/net/wireless/intel/iwlegacy/4965.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/wireless/intel/iwlegacy/4965.c b/drivers/net/wireless/intel/iwlegacy/4965.c > index ce4144a89217..a20b6c885047 100644 > --- a/drivers/net/wireless/intel/iwlegacy/4965.c > +++ b/drivers/net/wireless/intel/iwlegacy/4965.c > @@ -577,7 +577,6 @@ il4965_math_div_round(s32 num, s32 denom, s32 * res) > sign = -sign; > denom = -denom; > } > - *res = 1; > *res = ((num * 2 + denom) / (denom * 2)) * sign; > > return 1;
Powered by blists - more mailing lists