lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 31 Mar 2019 16:52:41 +0200
From:   Andrew Lunn <>
To:     Heiner Kallweit <>
Cc:     Florian Fainelli <>,
        David Miller <>,
        "" <>
Subject: Re: [PATCH net-next] net: phy: improve genphy_read_status

> -	if (AUTONEG_ENABLE == phydev->autoneg) {
> +	if (phydev->autoneg == AUTONEG_ENABLE && phydev->link) {

Hi Heiner

I don't necessary agree with placing the constant first in the
comparison, but it is best practice not to change it when making
additions. It makes it a little bit harder to see what the actual
change was.


Powered by blists - more mailing lists