[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 31 Mar 2019 16:52:41 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Florian Fainelli <f.fainelli@...il.com>,
David Miller <davem@...emloft.net>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: phy: improve genphy_read_status
> - if (AUTONEG_ENABLE == phydev->autoneg) {
> + if (phydev->autoneg == AUTONEG_ENABLE && phydev->link) {
Hi Heiner
I don't necessary agree with placing the constant first in the
comparison, but it is best practice not to change it when making
additions. It makes it a little bit harder to see what the actual
change was.
Andrew
Powered by blists - more mailing lists