lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 1 Apr 2019 00:12:06 +0200 From: Pablo Neira Ayuso <pablo@...filter.org> To: Flavio Leitner <fbl@...close.org> Cc: netdev@...r.kernel.org, Joe Stringer <joe@....org>, Pravin B Shelar <pshelar@....org>, dev@...nvswitch.org, netfilter-devel@...r.kernel.org Subject: Re: [PATCH net-next 2/8] netfilter: add API to manage NAT helpers. On Tue, Mar 26, 2019 at 05:57:09PM -0300, Flavio Leitner wrote: [...] > diff --git a/net/netfilter/nf_conntrack_helper.c b/net/netfilter/nf_conntrack_helper.c > index 274baf1dab87..883a8d438503 100644 > --- a/net/netfilter/nf_conntrack_helper.c > +++ b/net/netfilter/nf_conntrack_helper.c > @@ -42,6 +42,9 @@ module_param_named(nf_conntrack_helper, nf_ct_auto_assign_helper, bool, 0644); > MODULE_PARM_DESC(nf_conntrack_helper, > "Enable automatic conntrack helper assignment (default 0)"); > > +static struct list_head nf_ct_nat_helpers __read_mostly; > +static DEFINE_SPINLOCK(nf_ct_nat_helpers_lock); Why a spinlock here? Use mutex instead I'd suggest. Thanks.
Powered by blists - more mailing lists