netdev - Re: [PATCH net-next] r8169: use netif_receive_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190401.104120.332857372325942809.davem@davemloft.net>
Date:   Mon, 01 Apr 2019 10:41:20 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     brouer@...hat.com
Cc:     eric.dumazet@...il.com, hkallweit1@...il.com, nic_swsd@...ltek.com,
        netdev@...r.kernel.org, ecree@...arflare.com
Subject: Re: [PATCH net-next] r8169: use netif_receive_skb_list batching

From: Jesper Dangaard Brouer <brouer@...hat.com>
Date: Mon, 1 Apr 2019 14:53:26 +0200

> On Mon, 1 Apr 2019 02:17:12 -0700
> Eric Dumazet <eric.dumazet@...il.com> wrote:
> 
>> On 03/31/2019 11:11 AM, David Miller wrote:
>> > From: Heiner Kallweit <hkallweit1@...il.com>
>> > Date: Sun, 31 Mar 2019 15:18:48 +0200
>> >   
>> >> Use netif_receive_skb_list() instead of napi_gro_receive() to benefit
>> >> from batched skb processing.
>> >>
>> >> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>  
>> > 
>> > Applied.
>> >   
>> 
>> This means no GRO at all, and reduced performance in many useful
>> cases.
> 
> As Eric says, this in-effect disables GRO for this driver.

Really?  __netif_receive_skb_list_core() does GRO.