netdev - Re: [PATCH net-next] r8169: use netif_receive_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f59aa498-673d-3a4a-efb7-256a86fe720b@solarflare.com>
Date:   Mon, 1 Apr 2019 18:31:39 +0100
From:   Edward Cree <ecree@...arflare.com>
To:     David Miller <davem@...emloft.net>, <eric.dumazet@...il.com>
CC:     <hkallweit1@...il.com>, <nic_swsd@...ltek.com>,
        <netdev@...r.kernel.org>, <brouer@...hat.com>
Subject: Re: [PATCH net-next] r8169: use netif_receive_skb_list batching

On 01/04/2019 18:14, David Miller wrote:
> From: Eric Dumazet <eric.dumazet@...il.com>
> Date: Mon, 1 Apr 2019 02:17:12 -0700
>
>> This means no GRO at all
> I do not think that is true as the SKB list layer does queue up to
> GRO.
No, Eric is right; the current list layer bypasses GRO completely.

netif_receive_skb_list() ends up doing the same things netif_receive_skb()
would do on each SKB in the list, and that does not include GRO.
(For this reason the sfc driver only uses netif_receive_skb_list() for
non-TCP packets; TCP packets go to napi_gro_frags().)
I had a patch series to add napi_gro_receive_list() which would use the
SKB list layer to handle the packets GRO didn't coalesce ([1]) but the
performance tests I ran were inconclusive and it never got applied.

-Ed

[1]: https://marc.info/?l=linux-netdev&m=154221888012410&w=2