netdev - Re: [PATCH] tcp: fix a potential NULL pointer dereference in tcp_sk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190401.101234.1259757550586433319.davem@davemloft.net>
Date:   Mon, 01 Apr 2019 10:12:34 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     dust.li@...ux.alibaba.com, kuznet@....inr.ac.ru,
        yoshfuji@...ux-ipv6.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, caspar@...ux.alibaba.com
Subject: Re: [PATCH] tcp: fix a potential NULL pointer dereference in
 tcp_sk_exit

From: Eric Dumazet <edumazet@...gle.com>
Date: Mon, 1 Apr 2019 02:23:39 -0700

> On Mon, Apr 1, 2019 at 1:05 AM dust.li <dust.li@...ux.alibaba.com> wrote:
>>
>> From: Dust Li <dust.li@...ux.alibaba.com>
>>
>>  When tcp_sk_init() failed in inet_ctl_sock_create(),
>>  'net->ipv4.tcp_congestion_control' will be left
>>  uninitialized, but tcp_sk_exit() hasn't check for
>>  that.
>>
>>  This patch add checking on 'net->ipv4.tcp_congestion_control'
>>  in tcp_sk_exit() to prevent NULL-ptr dereference.
>>
>> Signed-off-by: Dust Li <dust.li@...ux.alibaba.com>
> 
> Fixes: 6670e1524477 ("tcp: Namespace-ify sysctl_tcp_default_congestion_control")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

This patch didn't make it to the list for whatever reason, but I applied it and
have it queued up for -stable.

Thanks.