netdev - Re: [PATCH net-next] tcp: cleanup sk_tx_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190329.131711.2043491726296499419.davem@davemloft.net>
Date:   Fri, 29 Mar 2019 13:17:11 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com, soheil@...gle.com,
        willemb@...gle.com
Subject: Re: [PATCH net-next] tcp: cleanup sk_tx_skb_cache before reuse

From: Eric Dumazet <edumazet@...gle.com>
Date: Fri, 29 Mar 2019 12:46:17 -0700

> TCP stack relies on the fact that a freshly allocated skb
> has skb->cb[] and skb_shinfo(skb)->tx_flags cleared.
> 
> When recycling tx skb, we must ensure these fields are cleared.
> 
> Fixes: 472c2e07eef0 ("tcp: add one skb cache for tx")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied, thanks Eric.