netdev - Re: [PATCH net-next] macsec: add noinline tag to avoid a frame size warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190401205143.GA19447@bistromath.localdomain>
Date:   Mon, 1 Apr 2019 22:51:43 +0200
From:   Sabrina Dubroca <sd@...asysnail.net>
To:     Florian Westphal <fw@...len.de>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net-next] macsec: add noinline tag to avoid a frame size
 warning

2019-04-01, 11:37:50 +0200, Florian Westphal wrote:
> seen with debug config:
> drivers/net/macsec.c: In function 'dump_secy':
> drivers/net/macsec.c:2597: warning: the frame size of 2216 bytes is larger
> than 2048 bytes [-Wframe-larger-than=]
> 
> just mark it with noinline_for_stack, this is netlink dump code.
> 
> Cc: Sabrina Dubroca <sd@...asysnail.net>
> Signed-off-by: Florian Westphal <fw@...len.de>
> ---
>  drivers/net/macsec.c | 22 ++++++++++++----------
>  1 file changed, 12 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c
> index 947c40f112d1..dbea9452b19a 100644
> --- a/drivers/net/macsec.c
> +++ b/drivers/net/macsec.c
> @@ -2175,8 +2175,9 @@ static int copy_tx_sa_stats(struct sk_buff *skb,
>  	return 0;
>  }
>  
> -static int copy_rx_sa_stats(struct sk_buff *skb,
> -			    struct macsec_rx_sa_stats __percpu *pstats)
> +static int noinline_for_stack

Could you swap int/noinline_for_stack to be consistent with the rest?

static noinline_for_stack int

Other than that, lgtm, thanks.

-- 
Sabrina